[Obs AI Assistant] Avoid showing error toast when action is aborted b… #195331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viduni94
added
release_note:fix
v9.0.0
backport:prev-minor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
botelastic
bot
added
the
ci:project-deploy-observability
viduni94
force-pushed
the
avoid-showing-error-toast-on-stop-generating
branch
from
0c18eb1 to
3eb2372
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
Historycc @viduni94 |
neptunian
approved these changes
Oct 8, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11235277597 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
elastic#195331) Closes elastic#186794 ## Summary ### Problem When the user clicks on "Stop generating" while the AI Assistant is generating an answer, an error toast is shown with the error message "Aborted". This is unnecessary as the user knows they aborted their action. ### Solution Do not show an error toast if the action is aborted by the user. (cherry picked from commit 43a3d4a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
…rted b… (#195331) (#195396) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Avoid showing error toast when action is aborted b… (#195331)](#195331) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T12:20:38Z","message":"[Obs AI Assistant] Avoid showing error toast when action is aborted b… (#195331)\n\nCloses https://github.com/elastic/kibana/issues/186794\r\n\r\n## Summary\r\n\r\n### Problem\r\nWhen the user clicks on \"Stop generating\" while the AI Assistant is\r\ngenerating an answer, an error toast is shown with the error message\r\n\"Aborted\". This is unnecessary as the user knows they aborted their\r\naction.\r\n\r\n### Solution\r\nDo not show an error toast if the action is aborted by the user.","sha":"43a3d4a68ada67a584686b223ea8d798f4018cde","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability"],"title":"[Obs AI Assistant] Avoid showing error toast when action is aborted b…","number":195331,"url":"https://github.com/elastic/kibana/pull/195331","mergeCommit":{"message":"[Obs AI Assistant] Avoid showing error toast when action is aborted b… (#195331)\n\nCloses https://github.com/elastic/kibana/issues/186794\r\n\r\n## Summary\r\n\r\n### Problem\r\nWhen the user clicks on \"Stop generating\" while the AI Assistant is\r\ngenerating an answer, an error toast is shown with the error message\r\n\"Aborted\". This is unnecessary as the user knows they aborted their\r\naction.\r\n\r\n### Solution\r\nDo not show an error toast if the action is aborted by the user.","sha":"43a3d4a68ada67a584686b223ea8d798f4018cde"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195331","number":195331,"mergeCommit":{"message":"[Obs AI Assistant] Avoid showing error toast when action is aborted b… (#195331)\n\nCloses https://github.com/elastic/kibana/issues/186794\r\n\r\n## Summary\r\n\r\n### Problem\r\nWhen the user clicks on \"Stop generating\" while the AI Assistant is\r\ngenerating an answer, an error toast is shown with the error message\r\n\"Aborted\". This is unnecessary as the user knows they aborted their\r\naction.\r\n\r\n### Solution\r\nDo not show an error toast if the action is aborted by the user.","sha":"43a3d4a68ada67a584686b223ea8d798f4018cde"}}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186794
Summary
Problem
When the user clicks on "Stop generating" while the AI Assistant is generating an answer, an error toast is shown with the error message "Aborted". This is unnecessary as the user knows they aborted their action.
Solution
Do not show an error toast if the action is aborted by the user.